From 08985f693620b8736411126e08b61920f3079e5c Mon Sep 17 00:00:00 2001 From: Yiyang Kang Date: Mon, 20 Mar 2023 19:49:59 +0800 Subject: [PATCH 1/2] fix: message not cached correctly --- assistant.go | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/assistant.go b/assistant.go index a7f9430..4e05fe0 100644 --- a/assistant.go +++ b/assistant.go @@ -31,6 +31,12 @@ func matchAssistantConversation(botUsr *tele.User, msg *tele.Message) []*tele.Me } for _, msg := range thread { + for _, ent := range msg.Entities { + if ent.Type == tele.EntityCommand { + return nil + } + } + from := msg.Sender chat := msg.Chat if from == nil || chat == nil { @@ -84,7 +90,7 @@ func matchAssistantConversation(botUsr *tele.User, msg *tele.Message) []*tele.Me type assistantStreamedResponseCb func(text string, finished bool) (*tele.Message, error) func assistantStreamedResponse(request openai.ChatRequest, cb assistantStreamedResponseCb) error { - logger.Debugf("Openai chat request: %#+v", request) + logger.Debugw("Openai chat request", "req", request) ai := openai.NewClient(config.OpenAIApiKey) resp, err := ai.ChatCompletionStream(request) @@ -188,7 +194,7 @@ func handleAssistantConversation(c tele.Context, thread []*tele.Message) error { role := openai.ChatRoleUser from := thread[l].Sender if from != nil && from.ID == me.ID { - role = openai.ChatRoleSystem + role = openai.ChatRoleAssistant } convMsgs = append(convMsgs, openai.ChatMessage{ @@ -221,11 +227,12 @@ func handleAssistantConversation(c tele.Context, thread []*tele.Message) error { var err error if replyMsg == nil { <-typingNotifyCh - replyMsg, err = c.Bot().Reply(c.Message(), text, tele.Silent) + replyMsg, err = c.Bot().Reply(lastMsg, text, tele.Silent) } else { replyMsg, err = c.Bot().Edit(replyMsg, text) } if finished && err == nil { + replyMsg.ReplyTo = lastMsg // nasty bug if err := cacheMessage(replyMsg); err != nil { logger.Warnw("failed to cache message", "error", err) } From 7e9d4e5052ca5917c20e3b29064b254d1575edb3 Mon Sep 17 00:00:00 2001 From: Yiyang Kang Date: Mon, 20 Mar 2023 19:50:24 +0800 Subject: [PATCH 2/2] feat(assistant): add retry when requesting completion --- assistant.go | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/assistant.go b/assistant.go index 4e05fe0..3e115b0 100644 --- a/assistant.go +++ b/assistant.go @@ -93,9 +93,19 @@ func assistantStreamedResponse(request openai.ChatRequest, cb assistantStreamedR logger.Debugw("Openai chat request", "req", request) ai := openai.NewClient(config.OpenAIApiKey) - resp, err := ai.ChatCompletionStream(request) - if err != nil { - return err + var ( + resp *openai.ChatResponseStream + err error + ) + tries := 2 + for { + if tries--; tries < 0 { + return err + } + if resp, err = ai.ChatCompletionStream(request); err == nil { + break + } + logger.Warnw("assistant: failed to get response", "error", err) } nErrs := 0 @@ -242,8 +252,9 @@ func handleAssistantConversation(c tele.Context, thread []*tele.Message) error { if reqErr != nil { logger.Errorw("assistant: failed to complete conversation", "error", reqErr) + return c.Reply("Sorry, there's a technical issue. 😵💫 Please try again later.", tele.Silent) } - return reqErr + return nil } func assistantRemoveMention(msg, name string) string {